Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin vite plugin to next.5 until issues are resolved #1026

Merged
merged 6 commits into from
Apr 15, 2021

Conversation

Rich-Harris
Copy link
Member

I think we need to pin vite-plugin-svelte to next.5 until the dev-time FOUC is resolved, since it's causing unrelated tests to fail. cc @dominikg

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@dominikg
Copy link
Member

the css links in head to SSR'd component styles generated here: https://github.com/sveltejs/kit/blob/master/packages/kit/src/core/dev/index.js#L232..L245
may be causing this issue: #718

vite-plugin-svelte 1.0.0-next.6 changed the vitural css module id format
from Foo.svelte.css?svelte&type=style
to Foo.svelte?svelte&type=style&lang.css
This was done to fix this: sveltejs/vite-plugin-svelte#14

Due to that change kit no longer detects the .css ending and doesn't create a link in head during ssr. That should fix #718 at the expense of fouc on dev.

Not sure why the pipelines in this PR failed so spectacularly, but might i suggest that users can pick their poison via pnpm overrides https://pnpm.io/package_json#pnpmoverrides until we fixed this for good in both cases?

@Rich-Harris
Copy link
Member Author

The pipelines failed because I accidentally moved the package to devDependencies from dependencies, so Rollup tried to bundle it 🤦

@Rich-Harris Rich-Harris mentioned this pull request Apr 15, 2021
5 tasks
@Rich-Harris Rich-Harris merged commit f870909 into master Apr 15, 2021
@Rich-Harris Rich-Harris deleted the pin-vite-plugin branch April 15, 2021 01:38
@Rich-Harris
Copy link
Member Author

Merging this on a temporary basis, in full acknowledgment that it's not an ideal solution, because it'll make it too hard to work on other stuff if tests keep failing. I had a go at a fix in #1031 but there's a missing piece

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants