fix: prevent duplicate <link> module preloads
#10442
Conversation
🦋 Changeset detectedLatest commit: cd55ab3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Crazy, it's failing a seemingly completely unrelated test, but consistently. |
Apparently, disabling Vite's module preload causes client-side navigation to not load the subsequent page's CSS files. Hence, the test is failing because the required CSS rules are not applied. I've changed it to only disable Vite's JS module preloading, but Kit still relies on Vite to inject the CSS link tag in the head for client-side navigation. Therefore, the duplicate CSS issue is still present |
|
Instead of messing with Vite's module preload option, we might have to prefer absolute asset URLs by default. |
|
To me it sounds like we should then revert that perf optimisation then for the time being. |
|
I've adjusted so that it is no longer the default, but the optimisation still works if the |
won't that create duplicate module preload it seems to me like the better way might be to update that section of code you referred to: https://github.com/sveltejs/kit/blob/926c22d94fe7884dc9bc020ce735a911f50c8509/packages/kit/src/runtime/server/page/render.js#L96C4-L108 |
It shouldn't as long as the base path settings match for both sections of code (either
Yes, initially I was inclined to change it so that root-relative was the default, but I'm not sure if that would cause problems for existing apps that relied on the default setting (relative paths)? The default behaviour as mentioned in the docs:
We would be changing the default to
- if (paths.relative !== false && !state.prerendering?.fallback) {
+ if (paths.relative && !state.prerendering?.fallback) {
// only use relative paths if explicitly set in svelte.config.js |
fixes #10358
fixes #10379
This PR disables Vite's module preload for JS files only (Vite still injects CSS) which adds the preloads on startup in addition to the preloads already added by Kit. I'm not currently aware of any side-effects disabling this may have so this PR might be somewhat naive.This PR matches the Vite base path setting optimisation with the page rendering base path setting, resulting in identical hrefs. Hence, Vite no longer duplicates asset links that are already in the
<head>.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.