Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "false" value to preload link options #10555

Merged
merged 2 commits into from Dec 12, 2023
Merged

Conversation

eltigerchino
Copy link
Member

closes #10460

Explanation: #10460 (comment)

We should update the language tools as well. I think the original PR from @alesvaupotic originates from the extension incorrectly stating that "false" is not a valid value (although it is for the non-preloading link options).

incorrect error message for svelte kit's link option

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: fb4f7f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@dummdidumm
Copy link
Member

The other link options support false since #10039, though the preload link options were seemingly deliberately left out - I'm not sure if this just slipped through or was a conscious decision. Maybe @Rich-Harris remembers.

@eltigerchino eltigerchino added the needs-decision Not sure if we want to do this yet, also design work needed label Dec 3, 2023
@dummdidumm
Copy link
Member

We can merge this into SvelteKit 1 (I'm in favor) but we can't change the types to include "false" until SvelteKit 3 because of potentially conflicting type definitions (SvelteKit 2 will have these definitions under its own control, but it supports Svelte 4 which also provides these, and so we can't have conflicts in there)

@dummdidumm dummdidumm merged commit b320e1e into master Dec 12, 2023
14 checks passed
@dummdidumm dummdidumm deleted the fix-link-options branch December 12, 2023 19:13
@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-decision Not sure if we want to do this yet, also design work needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants