Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow optional param in middle of route #10736

Merged

Conversation

danieldiekmeier
Copy link
Contributor

@danieldiekmeier danieldiekmeier commented Sep 15, 2023

I have a route with multiple optional params, but both have matchers that are exclusive to each other. That means for a given URL, there is no ambiguity which param matches.

Consider this example:

Route:           /[user]/[[type=type]]/[[page=page]]
Matcher `type`:  (param) => ["overview", "finished", "pending"].includes(param)
Matcher `page`:  (param) => /^\d+$/.test(param) && Number(param) > 0

Link:            "/daniel/2"
Expected Params: { user: "daniel", page: "2" }
Actual Result:   No match, SvelteKit raises 404

Looking at the code and the test cases, I think this might have been an accidental oversight, just due to the pretty complex routing algorithm.

This fix now allows the variant where all values have been matched and all params have been used.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

🦋 Changeset detected

Latest commit: fba6ab3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit 7ca6f01 into sveltejs:master Sep 19, 2023
13 checks passed
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
@danieldiekmeier danieldiekmeier deleted the allow-optional-param-in-middle branch September 28, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants