Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basic mime type handling for prerendered pages in preview #10851

Merged
merged 2 commits into from Oct 17, 2023

Conversation

benmccann
Copy link
Member

closes #10839

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

🦋 Changeset detected

Latest commit: 580e871

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

This looks to do more than just fix the MIME types for prerendered pages in vite preview - it's also switching MIME lookup libraries. I see the one this is switching to is by Luke (is this what's used internally by sirv?), but still, could changing this break anything for anyone?

@benmccann
Copy link
Member Author

Yeah, I thought I'd swap it out to reduce the number of dependencies since we're already pulling in mrmime via sirv. I feel like it'd be pretty unlikely to break anything because if a mime type is recognized by mime, but not mrmime, then it will be unable to be served by sirv today anyway

@eltigerchino eltigerchino merged commit 0381fee into master Oct 17, 2023
14 checks passed
@eltigerchino eltigerchino deleted the mime branch October 17, 2023 17:20
@github-actions github-actions bot mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite preview does not set correct mime types for some static files (e.g. xml)
3 participants