Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply adapter-cloudflare trailing slash fix to adapter-cloudflare-workers #10968

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Nov 2, 2023

fixes #10937

This PR applies the same adapter-cloudflare fix from #8733 which I forgot to add to adapter-cloudflare-workers in the past. This should fix the trailing slash issue in the aforementioned issue where the trailing slash of /base/ was being stripped too early and therefore, would never match with the prerendered page /base/.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 4d6edbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: apply adapter-cloudflare routing logic fix to adapter-cloudflare-workers fix: apply adapter-cloudflare trailing slash fix to adapter-cloudflare-workers Nov 2, 2023
@nosovk
Copy link
Contributor

nosovk commented Nov 7, 2023

@benmccann please don't mind if I tag wrong person, I'm not sure who is a code owner of cloudflare-adapter, but could it be that you can merge that pull request?

@benmccann
Copy link
Member

Yeah, I've been rather busy prepping for Svelte Summit this Saturday, but I'll get back to reviewing PRs after that

@benmccann benmccann merged commit 87a18b7 into master Nov 13, 2023
13 checks passed
@benmccann benmccann deleted the fix-cf-workers-trailing-slash branch November 13, 2023 02:22
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter-cloudflare-workers produces broken build with kit.paths.base filled with some subpath
3 participants