Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: note @migration comments, fix cookie migration #11331

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix: note @migration comments, fix cookie migration #11331

merged 2 commits into from
Dec 15, 2023

Conversation

hyunbinseo
Copy link
Contributor

@hyunbinseo hyunbinseo commented Dec 15, 2023

Migrating users should manually update cookie path arguments.
Also fixes cookie migration logic, fixes #11327


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: 0f52005

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-migrate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - not everyone might have cookies, so always printing the message might be confusing. I added it to the conditional log instead. Also did a fix while I'm at it.

@dummdidumm dummdidumm changed the title chore: inform @migration comments fix: note @migration comments, fix cookie migration Dec 15, 2023
@dummdidumm dummdidumm merged commit 88ce6b0 into sveltejs:master Dec 15, 2023
10 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Dec 15, 2023
@hyunbinseo hyunbinseo deleted the patch-3 branch December 15, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sveltekit 2.0 Migrate Scripts adds comments to unrelated delete Method
2 participants