Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct images cache key to avoid collisions when images have same name #11602

Merged
merged 3 commits into from Jan 11, 2024

Conversation

IAkumaI
Copy link
Contributor

@IAkumaI IAkumaI commented Jan 11, 2024

Fixes #11561
Images cache keys are wrong for relative paths


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [ x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: 5a2313b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/enhanced-img Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

As a heads up, I've updated the PR description to say "Fixes #11561", which links the PR and issue together in GitHub

@benmccann benmccann changed the title Fix #11561 wrong images cache key fix: correct images cache key to avoid collisions when images have same name Jan 11, 2024
@benmccann
Copy link
Member

I noticed you sent this PR from your main branch. That's fine for a single PR, but makes it difficult to send additional PRs in the future. You're usually best off making a new branch when you want to send a PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@IAkumaI
Copy link
Contributor Author

IAkumaI commented Jan 11, 2024

I noticed you sent this PR from your main branch. That's fine for a single PR, but makes it difficult to send additional PRs in the future. You're usually best off making a new branch when you want to send a PR

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sveltejs/enhanced-img shows the same image if file name is the same
2 participants