Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update welcome message #1196

Merged
merged 5 commits into from
Apr 24, 2021
Merged

update welcome message #1196

merged 5 commits into from
Apr 24, 2021

Conversation

Rich-Harris
Copy link
Member

Not sure how the typo ('some feature might not work yet') escaped our notice this long, but I figured I'd take the opportunity to tighten up the welcome message a bit generally

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris
Copy link
Member Author

Fixed a couple of other rough onboarding edges

@Conduitry
Copy link
Member

I know we've changed our mind at least a time or two about whether to include an adapter by default. What's behind this latest decision?

@Rich-Harris
Copy link
Member Author

a) I just think it's a bit weird to make the Node adapter the default, b) running into that message when you first build makes it much clearer that you're supposed to select an adapter, and makes it more likely that someone will figure out how (and be aware of the various options). In the past I think we had to include one because it failed if you didn't

@Rich-Harris Rich-Harris merged commit 6f2b4a6 into master Apr 24, 2021
@Rich-Harris Rich-Harris deleted the fix-welcome-message branch April 24, 2021 01:36
@Rich-Harris
Copy link
Member Author

i am perturbed by these windows failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants