Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip hydrate if ssr: false #12050

Merged
merged 2 commits into from Mar 28, 2024
Merged

skip hydrate if ssr: false #12050

merged 2 commits into from Mar 28, 2024

Conversation

Rich-Harris
Copy link
Member

Should fix sveltejs/svelte#10929

When using Svelte 5, we're always calling hydrate(...) instead of mount(...), even if the landing page was ssr = false. This PR fixes it.

Later, we can go a little bit further: by creating two entry points (one that references hydrate, one that references mount), and serving the mount entry point for ssr = false pages, we can take advantage of treeshaking to make the client bundle smaller in these cases. But it's probably not worth doing that until Svelte 5 is stable.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@Rich-Harris Rich-Harris merged commit f1a2133 into main Mar 28, 2024
13 checks passed
@Rich-Harris Rich-Harris deleted the skip-hydrate-if-ssr-false branch March 28, 2024 17:31
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
pboguslawski added a commit to ibpl/web-certificate-tool that referenced this pull request Apr 25, 2024
After sveltejs/kit#12050 application does not remove
initial loader after loading. Fix it by forcing removal
in layout.svelte.

Related: sveltejs/kit#12050
Author-Change-Id: IB#1144803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Beta.83 broke ssr = false in Svelte Kit
2 participants