Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit process with code 0 after successful adapt #1212

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Exit process with code 0 after successful adapt #1212

merged 1 commit into from
Apr 26, 2021

Conversation

Rich-Harris
Copy link
Member

fixes #978. Closes open db connections etc without needing to have an additional hook

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@DhyeyMoliya
Copy link

Can this be merged soon?

@Rich-Harris Rich-Harris merged commit ac60208 into master Apr 26, 2021
@Rich-Harris Rich-Harris deleted the gh-978 branch April 26, 2021 14:14
pzerelles pushed a commit to pzerelles/sveltekit that referenced this pull request Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop / shutdown hook to close database connections, etc.
2 participants