Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note that the prerenderer can't crawl pages that have SSR disabled #12226

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented May 17, 2024

There's some info missing regarding prerendering and ssr needing to both be enabled to have links discoverable by the prerenderer. This causes users some trouble as they need to discover this for themselves. #8688 (comment)

It may have been in our docs at some point but got removed as shown by the documentation link in this older issue that does not work #9913 (comment)


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino added the documentation Improvements or additions to documentation label May 17, 2024
Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: 0aaaa8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eltigerchino eltigerchino changed the title docs: note that the prerendered can't crawl pages that have SSR disabled docs: note that the prerenderer can't crawl pages that have SSR disabled May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants