Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate app.html, and throw in dev if target is missing #1304

Merged
merged 2 commits into from
May 2, 2021
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented May 2, 2021

fixes #1301. alternative to #1302 that does the validation earlier, so that it applies to build as well as dev, and throws an error in dev if the target element can't be found.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

Copy link
Contributor

@Kapsonfire-DE Kapsonfire-DE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1302 #1301 good to check it for build as well

@benmccann benmccann merged commit 427e8e0 into master May 2, 2021
@benmccann benmccann deleted the gh-1301 branch May 2, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning in SSR when %svelte.head% or %svelte.body% is missing in template file
3 participants