-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename $layout to __layout, etc #1370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amusingly, I think the __tests__.js
files are now tripping the rule about not being able to start a file with two underscores unless it's one of the known ones.
whoops AFK for a bit, will fix later if no-one beats me to it |
This change makes working with Go a nightmare because of this: golang/go#43854. Can we add a config option for this, @Rich-Harris? |
@Rich-Harris any updates on the config option? |
As a workaround, I added multiple paths and it worked fine with the sveltekit demo. Note the
Also note that files cannot be embedded from the parent directories of the go file where they are embedded. (no |
The
|
@rohfle I think it will be available from 1.18, right? |
@frederikhors the |
Closes #1149.
__
, so that we can add more special files in future without breakage$layout
etccreate a utility for renaming files?npx @sveltejs/kit-rename-files
or something?Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
Changesets
pnpx changeset
and following the prompts