Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ServerResponse Headers more flexible #1375

Merged
merged 4 commits into from
May 9, 2021
Merged

fix: make ServerResponse Headers more flexible #1375

merged 4 commits into from
May 9, 2021

Conversation

ignatiusmb
Copy link
Member

Fixes #1369

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@elliott-with-the-longest-name-on-github
Copy link
Contributor

Thanks for making this @ignatiusmb! It's a minor change, but not having pointless red files will be nice.

@Rich-Harris Rich-Harris merged commit 9e20873 into sveltejs:master May 9, 2021
@ignatiusmb ignatiusmb deleted the gh-1369 branch May 9, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing of ServerResponse doesn't jive with possibly undefined cookies (TypeScript)
4 participants