Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter body types, etags for binary responses #1382

Merged
merged 9 commits into from
May 9, 2021

Conversation

Rich-Harris
Copy link
Member

supersedes #1381, fixes #1136. Updates request/response body types, and generates etags for binary bodies

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris Rich-Harris merged commit 11e7840 into master May 9, 2021
@Rich-Harris Rich-Harris deleted the stricter-body-types branch May 9, 2021 16:48
@drzax
Copy link

drzax commented May 11, 2021

These stricter body types appear to prevent serving image binaries with the correct content-type. Unless I've missed something, or misunderstood how they should be served. Previously this worked, but now serves a 500 because Buffer is an instance of Uint8Array.

    return {
      headers: {
        'Content-Type': `image/png`
      },
      body: bufferContainingImageBinary
    };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETag generation throws on binary responses since 1.0.0-next.82
2 participants