Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailingSlash option #1404

Merged
merged 4 commits into from
May 11, 2021
Merged

Add trailingSlash option #1404

merged 4 commits into from
May 11, 2021

Conversation

Rich-Harris
Copy link
Member

Closes #733 (though I'll open a new issue for the "smart" option).

This adds trailingSlash: 'never' | 'always' | 'ignore', which keeps the existing default behaviour but also makes it easy to build sites that work with static hosting providers that expect a trailing slash for index.html pages, and provides an escape hatch for anyone that needs more complex behaviour.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris Rich-Harris merged commit 9a2cc0a into master May 11, 2021
@Rich-Harris Rich-Harris deleted the gh-733 branch May 11, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trailing slash removed when navigating
2 participants