Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adapter-netlify query params splitting (#1466) #1467

Merged
merged 3 commits into from
May 18, 2021

Conversation

adamjkb
Copy link
Contributor

@adamjkb adamjkb commented May 16, 2021

Instead of manually recreating the query parameters object from Netlify Functions' queryStringParameters object it is directly using the rawQuery object to create the URLSearchParams.

Fixes #1466

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except that you're bumping the version number more than we normally do

.changeset/cool-hounds-divide.md Outdated Show resolved Hide resolved
@benmccann
Copy link
Member

It looks to me like adapter-begin should be updated in the same way:

for (const k in queryStringParameters) {

Would you mind updating that one as well?

@adamjkb
Copy link
Contributor Author

adamjkb commented May 17, 2021

It looks to me like adapter-begin should be updated in the same way:

for (const k in queryStringParameters) {

Would you mind updating that one as well?

Sure thing, I updated that one as well.

@benmccann benmccann merged commit 1ba1784 into sveltejs:master May 18, 2021
andyburke pushed a commit to andyburke-forks/kit that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(adapter-netlify) Query params containing commas split after first comma
2 participants