ignore URLs that the app does not own #1487
Conversation
| const info = this.parse(url); | ||
|
|
||
| if (!info) { | ||
| throw new Error('Attempted to prefetch a URL that does not belong to this app'); |
There was a problem hiding this comment.
I wonder if it's worth trying to shorten this message the one below to save bytes shipped to the client such as: 'Attempted to prefetch external URL'
There was a problem hiding this comment.
i don't think 'external' is correct — nytimes.com isn't external to nytimes.com/interactive/2021/us/covid-cases.html, in the normal sense of that word in a URL context
| 'ignores navigation to URLs the app does not own', | ||
| '/routing', | ||
| async ({ page, clicknav }) => { | ||
| await clicknav('[href="https://www.google.com"]'); |
There was a problem hiding this comment.
there's some chance that this will cause tests to fail on the CI. I have no idea what Google will do if it thinks it's being hit by an automated bot. Maybe we should use svelte.dev?
There was a problem hiding this comment.
The extra safe version would probably be to spin up another server on localhost on a different port, but that might be more hassle than it's worth, especially if this is a fix you're trying to get out quickly.
There was a problem hiding this comment.
it works fine locally, so presumably google has no problem with it. agree that it's a potential source of flakiness, but realistically if google.com is inaccessible the internet probably has bigger problems that day
|
man this is not a convenient time for github actions to flake out |
Need to expedite a fix to this... if you have
<a>elements on the page that have the same origin but don't share abasepath with the app (to take a completely random example, a link to https://nytimes.com from https://www.nytimes.com/interactive/2021/us/covid-cases.html), the router will try to intercept the navigation but crashes. The same goes forprefetch.This PR adds a concept of URL 'ownership' that makes it possible to prevent situations like this from occurring.
Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintChangesets
pnpx changesetand following the prompts