Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to @iarna/toml package with better TOML language features support #1509

Merged
merged 2 commits into from
May 20, 2021
Merged

Switch to @iarna/toml package with better TOML language features support #1509

merged 2 commits into from
May 20, 2021

Conversation

jacob-8
Copy link
Contributor

@jacob-8 jacob-8 commented May 20, 2021

Fixes #1493 and allows Cloudflare Workers users and Netlify users to use features added to the TOML spec after v0.4.0 such as dotted keys like those described in https://developers.cloudflare.com/workers/cli-wrangler/configuration#service-workers

https://github.com/BinaryMuse/toml-node has gone stale at TOML spec v0.4.0
This PR switches to using https://github.com/iarna/iarna-toml as a lighter-weight, more up to date and equally used package.
https://github.com/LongTengDao/j-toml is slightly more up to date with the TOML spec (v1.0.0-rc.1 vs v1.0.0) but with very low usage and a bundle size 10x as large, I did not look into using it.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@benmccann benmccann merged commit 71e293d into sveltejs:master May 20, 2021
@jacob-8 jacob-8 deleted the change-toml-package-to-support-dotted-keys branch May 20, 2021 21:04
andyburke pushed a commit to andyburke-forks/kit that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change TOML parser to an active project that supports the latest TOML syntax
2 participants