Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vite.alias to be an array #1640

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Allow vite.alias to be an array #1640

merged 1 commit into from
Jun 11, 2021

Conversation

hgl
Copy link
Contributor

@hgl hgl commented Jun 5, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

I'm not sure how to test this, would like to be enlightened.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@hgl hgl closed this Jun 5, 2021
@hgl hgl reopened this Jun 5, 2021
@hgl
Copy link
Contributor Author

hgl commented Jun 5, 2021

What is this SyntaxError: Unexpected token '.' error? Tests passed on my local machine.

@benmccann
Copy link
Member

It's because ?. doesn't work on Node 12

@hgl
Copy link
Contributor Author

hgl commented Jun 5, 2021

Thanks, fixed.

@benmccann benmccann merged commit 17bf301 into sveltejs:master Jun 11, 2021
benmccann pushed a commit that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants