Add SW files exclusion support #1645
Conversation
|
This would need some documentation |
hariombalhara
force-pushed
the
sw-file-exclusions-support
branch
from
b4e75c7
to
dd56250
Compare
|
I have added the comments where I felt are justified. |
|
I meant to add something in https://github.com/sveltejs/kit/tree/master/documentation/docs so people know this option exists and how to use it |
|
@benmccann Oops. I thought you were talking about this only 😄 |
|
@benmccann please look into it. |
|
@hariombalhara it looks like this PR will need to be rebased |
|
Sure will do it today |
🦋 Changeset detectedLatest commit: d885066 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hariombalhara
force-pushed
the
sw-file-exclusions-support
branch
from
85941d4
to
c9f86e0
Compare
|
There are no conflicts now. |
|
@benmccann This is now sorted. I forgot to tag you. |
hariombalhara
force-pushed
the
sw-file-exclusions-support
branch
from
5e25674
to
c28a824
Compare
|
@benmccann @ignatiusmb I am done with all changes. |
|
|
This is fixed in #1725. Unrelated to this PR.
Sure. |
|
@benmccann Lint should be passing now. |
|
@Rich-Harris @benmccann Please take a look into this. |
|
@benmccann Please tell me the way forward on it. |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
|
Added changeset |
hariombalhara
force-pushed
the
sw-file-exclusions-support
branch
from
7768912
to
d885066
Compare
|
Thanks for reviewing and merging @benmccann! |
* 'master' of github.com:sidharthv96/kit: (1114 commits) Version Packages (next) (sveltejs#1858) Bump vite-plugin-svelte to 1.0.0-next.12 (sveltejs#1869) [fix] preserve user defined config and files on `svelte-kit package` (sveltejs#1735) [fix] handle undefined body on endpoint output (sveltejs#1808) [fix] copy essentials files from root on packaging (sveltejs#1747) [docs] sort config alphabetically (sveltejs#1867) add config.kit.package.emitTypes option (sveltejs#1852) [fix] add $lib alias to js/tsconfig (sveltejs#1860) Pass along custom properties added to Error (sveltejs#1821) Version Packages (next) (sveltejs#1840) Improve grammar in packages FAQ Docs for writing an adapter (sveltejs#1846) Additional documentation around pnpx changeset usage [feat] expose Vite.js `mode` from `$app/env` (sveltejs#1789) Service worker files exclusion support (sveltejs#1645) chore: Enable `vite.server.fs.strict` internally by default (sveltejs#1842) Test with the latest version of Svelte (sveltejs#1848) [docs] don't need to run pnpm install twice Improve HN example docs [fix] correct `ReadOnlyFormData` generator implementation (sveltejs#1837) ...
Before submitting the PR, please make sure you do the following
Suggested Fix for Issue: #1636
It supports files exclusions using glob patterns from $service-worker.files
This exclusion can also be helpful when you have certain files present due to any of the following reason
It allows you to control what you want to be cached during ServiceWorker installation, so installation time won't increase as your app grow.
I would add tests for the case once I get to know if I am going in the right direction
Tests
Changesets
Would generate a changelog later.