Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] adapter-netlify: return the right headers #1913

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

JeanJPNM
Copy link
Contributor

@JeanJPNM JeanJPNM commented Jul 15, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

While looking at possible causes for #1911 I found a logical error inside the entry of adapter-netlify, it was returing the request headers instead of the response headers.

Idk if this should have a changelog.

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2021

🦋 Changeset detected

Latest commit: 6f5695a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JeanJPNM JeanJPNM changed the title split the rendered headers [fix] return the right headers Jul 15, 2021
@JeanJPNM JeanJPNM changed the title [fix] return the right headers [fix] adapter-netlify: return the right headers Jul 15, 2021
@benmccann benmccann merged commit 67ca3a3 into sveltejs:master Jul 15, 2021
@JeanJPNM JeanJPNM deleted the fix/netlify-split-right-headers branch July 15, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants