Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make router-handled scrolling work with CSS properties #1972

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Make router-handled scrolling work with CSS properties #1972

merged 2 commits into from
Jul 20, 2021

Conversation

allezxandre
Copy link
Contributor

Fixes #1863.

Using scrollIntoView instead scrollTo naturally adds
support for more CSS scrolling properties when scrolling to IDs.

Properties like scroll-margin and scroll-behavior are supported by scrollIntoView.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test
  • Lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

allezxandre and others added 2 commits July 20, 2021 18:27
Using `scrollIntoView` instead `scrollTo` naturally adds
support for more CSS scrolling properties when scrolling to IDs.

Properties like `scroll-margin` and `scroll-behavior` are supported by `scrollIntoView`.
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2021

🦋 Changeset detected

Latest commit: f0167c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@allezxandre
Copy link
Contributor Author

This PR is ready, however I can't seem to make the tests pass (on this branch or on master's)

As my proposed change is tiny, I assume this isn't my change that breaks the tests?

@benmccann
Copy link
Member

The tests are all passing on the CI. Some are a bit flaky. Maybe they flake out more often on your machine

@benmccann benmccann merged commit 51ec789 into sveltejs:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hash scroll doesn't work with scroll-margin CSS property
2 participants