-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom error handler #2122
Custom error handler #2122
Conversation
🦋 Changeset detectedLatest commit: a342c35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome. thanks!
@Rich-Harris will you have access to global |
This may be naive of me, but any logging aggregation tool that I've used, I have an agent running on the server which periodically ships the logs from stdout back to the aggregator. The code in this PR, as I've observed, is only running server-side, so I don't think the client should ever have to be pushing logs back to the aggregator. So I think logging to stdout should be sufficient. |
3ad51bd
to
20e49e4
Compare
I'm not sure about the failing test from the last workflow run. all of the tests pass locally |
don't worry about it. most of the jobs passed. if it's just one failing then it's a flaky test |
Thank you — made some tweaks in #2193, will close this in favour of that |
Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0This PR replaces
handle_error
with a new hookhandleError
. Closes #1857. This will, by default, print errors as was happening before, or allow the user to define their own error handler.