Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] type functions as methods for semantics #2158

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

JeanJPNM
Copy link
Contributor

@JeanJPNM JeanJPNM commented Aug 10, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

This is a small change, replaces all occurences of function properties by methods.

Before:
before

After:
after

Edit: images modified to make example more clear

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2021

🦋 Changeset detected

Latest commit: 021e1bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was staring at the screenshot for a really long time trying to figure out the difference - it looks like cube vs rectangle icon in front of handler. Neither mean anything to me, but this change seems fine to me 😄

Copy link
Member

@ignatiusmb ignatiusmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was in one of my todo list for a while.

@ignatiusmb ignatiusmb changed the title [chore] Semantic ts methods [chore] type functions as methods for semantics Aug 11, 2021
@benmccann benmccann merged commit 1bed886 into sveltejs:master Aug 11, 2021
@JeanJPNM JeanJPNM deleted the semantic-ts-methods branch August 11, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants