Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kit peerDependency on svelte to ^3.39.0 #2182

Merged
merged 1 commit into from Aug 13, 2021

Conversation

dominikg
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

svelte 3.39.0 introduced a new export svelte/ssr with a noop for onMount
sveltejs/svelte#6372
which is supported by vite-plugin-svelte sveltejs/vite-plugin-svelte#74

To make sure users do profit from this improvement, raise the peer dependency version.
Example of a user with older svelte version: #2181

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2021

🦋 Changeset detected

Latest commit: 2779a33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg dominikg marked this pull request as draft August 12, 2021 21:00
@dominikg
Copy link
Member Author

would this be a breaking change?

@benmccann benmccann linked an issue Aug 12, 2021 that may be closed by this pull request
@benmccann
Copy link
Member

I suppose it's breaking, but that doesn't mean a whole lot given our beta phase. We can just apply the label to help people find it more easily

Any reason this is marked as draft?

@dominikg
Copy link
Member Author

the fact that it is breaking and i wanted to make sure it's seen/discussed before merge.

@benmccann benmccann marked this pull request as ready for review August 12, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "./ssr" export in "svelte" package
3 participants