Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] discover new routes in dev server #2198

Merged
merged 7 commits into from
Aug 15, 2021

Conversation

jasonlyu123
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes #2046. The manifest data passed into the server handler it's the initial manifest. And the manifest won't be mutated by reference but resigned. This PR changes to pass a get function to the handler so it'll get the up-to-date manifest.

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2021

🦋 Changeset detected

Latest commit: e357735

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ignatiusmb ignatiusmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are finally passing, this would be a really nice improvement for the dev server!

.changeset/tall-jeans-hear.md Outdated Show resolved Hide resolved
packages/kit/src/core/dev/index.js Outdated Show resolved Hide resolved
packages/kit/src/core/dev/index.js Outdated Show resolved Hide resolved
@ignatiusmb ignatiusmb changed the title [fix] fix new route discovery in the dev server [fix] discover new routes in dev server Aug 14, 2021
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@ignatiusmb ignatiusmb merged commit b3b4382 into sveltejs:master Aug 15, 2021
@benmccann benmccann mentioned this pull request Aug 17, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev server don't autodiscover new routes
3 participants