Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Make rawBody be the bytes #2215

Merged
merged 16 commits into from Aug 17, 2021
Merged

Conversation

JeanJPNM
Copy link
Contributor

@JeanJPNM JeanJPNM commented Aug 16, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Closes #1893 by ensuring rawBody is an Uint8Array before it is passed down to request handlers.

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2021

🦋 Changeset detected

Latest commit: bedda81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JeanJPNM JeanJPNM changed the title Binary raw body [chore] Make rawBody be the bytes Aug 16, 2021
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! i may not have fully understood everything, but it feels like we can simplify even further? comments inline

packages/kit/src/runtime/server/index.js Outdated Show resolved Hide resolved
packages/kit/src/runtime/server/parse_body/index.js Outdated Show resolved Hide resolved
packages/kit/src/runtime/server/parse_body/index.js Outdated Show resolved Hide resolved
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for those changes. i had one final question (see comments) then i think this is probably good to go

packages/kit/src/core/adapt/prerender.js Outdated Show resolved Hide resolved
packages/kit/src/core/adapt/prerender.js Outdated Show resolved Hide resolved
packages/kit/src/core/node/index.js Outdated Show resolved Hide resolved
packages/kit/src/core/node/index.js Outdated Show resolved Hide resolved
@Rich-Harris Rich-Harris merged commit 290a4ca into sveltejs:master Aug 17, 2021
@Rich-Harris
Copy link
Member

this change is a huge improvement — thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing rawBody to be the bytes
4 participants