[fix] register custom service worker for AMP #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 102f40e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
asendia
changed the title
ignatiusmb
reviewed
Aug 23, 2021
ignatiusmb
approved these changes
Aug 23, 2021
ignatiusmb
changed the title
Sorry if this is a stupid question since I am new to this, it seems like the test is failing on node 12 ubuntu-latest. Is this due to flaky test or something? 🙇🏼 |
|
Yes, it should be fine |
|
(belatedly) this is great, thank you so much! |
This was referenced Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2264
An attempt to fix invalid service-worker script tag in AMP as described in the issue
I am still not sure what is the best way to set
data-iframe-srcsince it must include the full domain name.