[fix] anchor tag inside svg #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e1f23b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Aug 25, 2021
benmccann
reviewed
Aug 25, 2021
bluwy
reviewed
Aug 25, 2021
benmccann
reviewed
Aug 25, 2021
|
It would be nice if these had some accompanying tests |
|
Looks like spaces and tabs are being mixed too. we'll need to normalize/format them as well |
|
I can clean up the formatting easily enough. I'll need some guidance regarding tests, though. I'm not sure where to begin with that. |
benmccann
reviewed
Aug 25, 2021
benmccann
reviewed
Aug 26, 2021
benmccann
reviewed
Aug 26, 2021
ignatiusmb
reviewed
Aug 26, 2021
|
You can try and take a look at the examples in |
benmccann
changed the title
benmccann
reviewed
Aug 28, 2021
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With anchor tags inside SVG elements, the href attribute is an object. The href value is at a.href.baseVal. However, this value differs from a normal anchor tag, in that it is not the full resolved path, so in order to pass it to a URL constructor, you have to include a base URL. This change handles SVG anchor tags correctly, including prefetch, and in the click event handler function.
Fixes #2256