[fix] don't de-indent user-rendered HTML #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db38f52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Have you checked what this produces? Is the rendered HTML as aesthetically pleasing as before, or is the serialized data unnecessarily indented? It doesn't matter a whole lot, but I'd probably prefer the output to look tidy rather than the SvelteKit code to look pretty, if we have to choose one or the other. |
benmccann
force-pushed
the
dont-replace
branch
from
b9de833
to
257d116
Compare
|
It looks worse, but not because the serialized data is indented, but because the HTML is indented. But I don't think we want to muck with the HTML Before
After
|
Conduitry
reviewed
Aug 25, 2021
Co-authored-by: Conduitry <git@chor.date>
benmccann
changed the title
Conduitry
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2289
Thanks to @Conduitry for the excellent investigation in tracking this down