[fix] pass along set-cookie headers during SSR #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f0bf9b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
force-pushed
the
set-cookie
branch
from
38af52c
to
f0bf9b7
Compare
|
Thanks Ben! |
dishuostec
reviewed
Sep 17, 2021
| @@ -219,7 +224,11 @@ export async function load_node({ | |||
| /** @type {import('types/helper').ResponseHeaders} */ | |||
| const headers = {}; | |||
| for (const [key, value] of response.headers) { | |||
| if (key !== 'etag' && key !== 'set-cookie') headers[key] = value; | |||
| if (key === 'set-cookie') { | |||
| set_cookie_headers = set_cookie_headers.concat(value); | |||
There was a problem hiding this comment.
The cookie value may included multiple k/v entries with comma joined see https://datatracker.ietf.org/doc/html/rfc2616#section-4.2. We should convert them to array of string. Here is a implementation: https://github.com/nfriedly/set-cookie-parser/blob/9cb7f099b9328bc6ab7b7c1eab31d8cfb41b2e44/lib/set-cookie.js#L126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1198