[feat] prefer functions to globs #2430
Conversation
🦋 Changeset detectedLatest commit: 2cfbc47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -132,8 +126,25 @@ Options related to [creating a package](#packaging). | |||
|
|
|||
| - `dir` - output directory | |||
| - `emitTypes` - by default, `svelte-kit package` will automatically generate types for your package in the form of `d.ts.` files. While generating types is configurable, we believe it is best for the ecosystem quality to generate types, always. Please make sure you have a good reason when setting it to `false` (for example when you want to provide handwritten type definitions instead) | |||
| - `exports` - contains an `includes` and an `excludes` array which specifies which files to mark as exported from the `exports` field of the `package.json`. Will merge existing values if available with values from `package.json` taking precedence | |||
| - `files` - contains an `includes` and an `excludes` array which specifies which files to process and copy over when packaging | |||
| - `exports` - a function with the type of `(filepath: string) => boolean`. When `true`, the following export will be included in the `exports` field of the `package.json`. Any existing values in the `package.json` source will be merged with values from the original `exports` field taking precedence | |||
There was a problem hiding this comment.
what does "the following export" refer to?
|
The micromatch example is a reference from #2374 (comment) |
|
@ignatiusmb it looks like this PR will need a rebase |
|
|
||
| ```js | ||
| // svelte.config.js | ||
| // example usage with a globbing library |
There was a problem hiding this comment.
I think I missed this comment earlier and I thought this was demonstrating a default or something. I somewhat question if we need this example, but if we want to keep it, I'd probably remove this comment and instead put it in the prose above like For advanced file matching you can use these options in conjunction with a globbing library:
|
This missed one of the references to We should get that fixed and get this released quickly, because anytime we merge PRs that update the docs, the site is redeployed right away, not when we release the feature to npm. |
|
Thanks for catching that. PR here: #2485 |
Resolves #2374