Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fixes for firing of hashchange event #2591

Merged
merged 2 commits into from
Oct 12, 2021
Merged

[fix] fixes for firing of hashchange event #2591

merged 2 commits into from
Oct 12, 2021

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Oct 12, 2021

fixes for hashchange (#2588) which was implemented in the last PR (#2590)

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2021

🦋 Changeset detected

Latest commit: d01e2df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

As a personal style thing, I'd probably prefer to use slice rather than substring because I can never remember what the difference is between substring and substr - whereas slice is really easy for me to remember and works the same way as on arrays.

If other people feel differently, I don't feel particularly strongly about this.

@benmccann
Copy link
Member Author

I'm the opposite, but maybe that's because I'd never heard of substr until today 😄 I can never remember what slice does because it's not in the other languages I use, but substring is the same in all of them

@benmccann benmccann merged commit 426a18e into master Oct 12, 2021
@benmccann benmccann deleted the hashchange2 branch October 12, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants