[fix] xss issue with dynamic route paths #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c32be2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dominikg
changed the title
Conduitry
approved these changes
Oct 13, 2021
dennisjlee
reviewed
Oct 19, 2021
|
|
||
| test('no xss via query param', `/xss/query?key=${uri_xss_payload}`, async ({ page }) => { | ||
| // @ts-expect-error - check global injected variable | ||
| assert.ok(!(await page.evaluate(() => window.pnwed)), 'pwned'); |
There was a problem hiding this comment.
sorry for the drive-by comment, but this is testing the wrong condition due to a typo. The XSS injection would set window.pwned but the two assertions are looking for window.pnwed
There was a problem hiding this comment.
Thanks! It looks like there are other things going on here besides just the typo, so I've opened issue #2648 for fixing this test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2596
uses try_serialize as suggested by @Conduitry , includes testcase that fails without this fix
Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0