Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] return list of copied files from copy utils #2674

Merged
merged 7 commits into from Oct 25, 2021
Merged

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Oct 24, 2021

Returns what files have been copied from the copy utilities provided to adapters. This way adapters can easily determine what files have been copied.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2021

🦋 Changeset detected

Latest commit: b198e93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

General thought: are there other things devs might want to have returned from this in the future? If yes, future-proof the API by returning an object with just the files property for now?

@pngwn
Copy link
Member Author

pngwn commented Oct 24, 2021

This returns the source of the copied files. the only additional thing I can think of returning is the target they are copied to. That can easily be deduced by the consumer, as this is a straightforward recursive copy, but that is the only other thing that comes to mind.

If we wanted to do this then we could return and object of { source: Array<string> } which could later be expanded to { source: Array<string>, target: Array<string> }

@benmccann benmccann changed the title Copy utils [feat] copy utils Oct 24, 2021
@benmccann benmccann changed the title [feat] copy utils [feat] return list of copied files from copy utils Oct 25, 2021
@benmccann benmccann merged commit fa25813 into master Oct 25, 2021
@benmccann benmccann deleted the copy-utils branch October 25, 2021 17:56
This was referenced Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants