Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] support data:image URLs in prerendering #2680

Closed
wants to merge 14 commits into from
Closed

[fix] support data:image URLs in prerendering #2680

wants to merge 14 commits into from

Conversation

gg187on
Copy link

@gg187on gg187on commented Oct 25, 2021

Issue is solving regex matching for static prerendered content with static adapter, when href contains data uris with inline svg and other stuff containing < and > characters.


Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2021

🦋 Changeset detected

Latest commit: 4a30493

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gg187on gg187on changed the title fix https://github.com/sveltejs/kit/issues/2645 fix 2645 data:image URL error Oct 25, 2021
@gg187on gg187on marked this pull request as ready for review October 25, 2021 13:30
@benmccann benmccann changed the title fix 2645 data:image URL error [fix] support data:image URLs in prerendering Oct 25, 2021
@gg187on gg187on marked this pull request as draft October 25, 2021 17:44
@gg187on gg187on marked this pull request as ready for review October 25, 2021 18:06
@gg187on gg187on closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant