Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] upgrade minor deps. fetch-blob 3.1.3 needed for Netlify deploys #2714

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

benmccann
Copy link
Member

Upgrade to fetch-blob 3.1.3 to make sure our deploys to Netlify succeed. This probably won't affect user projects which will need to do their own upgrades, but should help our own deploys of the examples

This is only half of the fix. The other half is for Netlify to bump a dependency on their side. PR pending for that: netlify/cli#3533

Ref #1859

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2021

🦋 Changeset detected

Latest commit: 7ccc17e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to update package.json too? That usually happens when running pnpm update -r

@benmccann
Copy link
Member Author

I don't really think it's necessary or possibly even desired as I think it'd make it slightly harder for users to pick older versions of libraries. It also would cause more merge conflicts with outstanding PRs.

@bluwy
Copy link
Member

bluwy commented Nov 1, 2021

I'm still not clear of your point 😅 but I think updating to the latest would be better in the long term. Merge conflicts in outstanding PRs would already be affected by the lock file change, so having the package.json updated as well could give them a hint of the dependencies that changed when resolving conflicts.

Nevertheless it's just a question I've thought of, I'm fine with the PR as is too.

@benmccann
Copy link
Member Author

With sem ver it's just as good to say ^3.0.0 as ^3.2.1. Or it's actually even better. It lets the user use 3.1.0 if they need to for some reason. Updating package.json would just update the minimum version allowed and not the actual version used

@bluwy
Copy link
Member

bluwy commented Nov 1, 2021

Yeah good point too. It was that I find updating to the latest version cleaner, and would imply being the version we officially support (especially if we use a new feature from a minor version). But being able to easily resolve to a lower version is a plus too.

@benmccann benmccann merged commit 7091c0f into master Nov 1, 2021
@benmccann benmccann deleted the fetch-blob-3.1.3 branch November 1, 2021 17:05
@github-actions github-actions bot mentioned this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants