[fix] use defaults when no opts passed to router #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e1bdb00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
reviewed
Nov 18, 2021
Co-authored-by: Bjorn Lu <34116392+bluwy@users.noreply.github.com>
bluwy
approved these changes
Nov 18, 2021
|
I've re-run the tests twice but it seems like a fluke consistently happening recently. It's likely the way we detect scrolls that's causing it but this change should be safe as is. Merging this to fix #2853 |
benmccann
added a commit
that referenced
this pull request
Nov 23, 2021
benmccann
added a commit
that referenced
this pull request
Nov 23, 2021
Rich-Harris
added a commit
that referenced
this pull request
Nov 24, 2021
* [fix] revert #2819 and add code comment * lint * Update packages/kit/src/runtime/client/renderer.js Co-authored-by: Bjorn Lu <34116392+bluwy@users.noreply.github.com> * reverse condition Co-authored-by: Rich Harris <richard.a.harris@gmail.com> Co-authored-by: Bjorn Lu <34116392+bluwy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this in another code review
There are somethings we don't do when
!opts. E.g. we don't do thedocument.body.focus();. I have no idea why this would be and it seems wrong