Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops package from breaking when given absolute path #3012

Merged
merged 4 commits into from Dec 11, 2021
Merged

Stops package from breaking when given absolute path #3012

merged 4 commits into from Dec 11, 2021

Conversation

ghostdevv
Copy link
Member

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

I was trying to figure out what's going on here: #3001 and discovered that absolute paths break.

Important: due to a different path issue with svelte2tsx (going to make a pr to fix this) the issue I linked above isn't fixed, if testing this pr disable dts emitting in package options so that the dts generation issue doesn't get in the way

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2021

🦋 Changeset detected

Latest commit: 5e44246

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghostdevv
Copy link
Member Author

Unsure why ci is failing, will see if I can figure out if it's related to this pr or not

.changeset/gold-colts-train.md Outdated Show resolved Hide resolved
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@bluwy
Copy link
Member

bluwy commented Dec 11, 2021

CI should be fixed now with #3022 merged. Rebasing this PR should fix it.

@ghostdevv
Copy link
Member Author

Amazing thank you @bluwy

@dummdidumm dummdidumm merged commit 484ea9a into sveltejs:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants