Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] invalid amp-install-serviceworker #3075

Merged
merged 6 commits into from Dec 25, 2021
Merged

[fix] invalid amp-install-serviceworker #3075

merged 6 commits into from Dec 25, 2021

Conversation

asendia
Copy link
Contributor

@asendia asendia commented Dec 20, 2021 •
edited

Fixes #3074 by injecting <amp-install-serviceworker> inside <body> instead of <head>. But user won't be able to customize the component.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2021 •
edited

🦋 Changeset detected

Latest commit: 21db87f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@asendia asendia mentioned this pull request Dec 20, 2021
Closed
asendia
asendia commented Dec 20, 2021
View reviewed changes
Copy link
Contributor Author

@asendia asendia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 175 is hard to read 😓

bluwy
bluwy reviewed Dec 22, 2021
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with amp, so I'm giving a general code quality review. I think we can add a test for this as well.

packages/kit/src/runtime/server/page/render.js Outdated Show resolved Hide resolved
Rich-Harris
Rich-Harris requested changes Dec 22, 2021
View reviewed changes
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! mind adding a changeset so this will trigger a new version?

@asendia @bluwy
Update packages/kit/src/runtime/server/page/render.js
fd9ec25 
Remove unnecessary string template

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@Rich-Harris Rich-Harris merged commit d0d04cd into sveltejs:master Dec 25, 2021
@github-actions github-actions bot mentioned this pull request Dec 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-install-service worker incorrect location
3 participants
@asendia @Rich-Harris @bluwy