Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status and error to page store #3096

Merged
merged 5 commits into from Dec 31, 2021

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Dec 23, 2021

related to #598

not sure how to add test for this

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2021

🦋 Changeset detected

Latest commit: ab378c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -754,6 +756,8 @@ export class Renderer {
params: {}
};

this.stores.error.set(error);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing on this line. You'll need to make sure pnpm check passes

@Rich-Harris
Copy link
Member

Since we've got rid of the page object in load functions in #3126, and stores.page now contains url and params directly, @Conduitry made the excellent observation that it should also include error and status rather than us having separate stores. This also conveniently solves any potential issues around stores getting out of sync (e.g. you're explicitly subscribing to both error and status and don't want to experience tearing)

@Rich-Harris Rich-Harris changed the title error readable store Add status and error to page store Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants