Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip navigation if only url hash change #3177

Merged
merged 5 commits into from Jan 3, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 2, 2022

Fixes #3105
Fixes #2667

If only the URL hash change when navigating via anchor tags, e.g. <a href="#foo">, skip router navigation and let the default browser behaviour to kick in.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@bluwy bluwy added the router label Jan 2, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2022

🦋 Changeset detected

Latest commit: ed91ca8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 2, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: ed91ca8

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d2e1b61fee1200089d0173

Comment on lines 192 to 195
await page.click('[href="#hash-target"]');
await clicknav('[href="/routing/hashes/b"]');

await back();
await page.goBack();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to page.click and page.goBack since the clicknav and back utils rely on sveltekit:navigation-end to resolve, which these hash-only anchor tags would skip, resulting in timeout.

Using playwright's builtin functions to avoid it.

);
},
// Does not work in nojs
{ nojs: false }
Copy link
Member Author

@bluwy bluwy Jan 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In no-js, the default page focus after Tab is the document body, which fails this test. I'm not entirely clear why it works in js, but I'm skipping this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus broken when navigating with hash CSS psuedo selector ':target' issue
2 participants