Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] relax endpoint headers type definition #3201

Merged
merged 3 commits into from Jan 4, 2022

Conversation

ignatiusmb
Copy link
Member

@ignatiusmb ignatiusmb commented Jan 4, 2022

Fixes #1369

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2022

🦋 Changeset detected

Latest commit: 63ebaa2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 63ebaa2

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d40610a61be0000735b116

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I wonder if we should set up some kind of type tests at some point to guard against such regressions in the future

@Rich-Harris Rich-Harris merged commit 2839689 into master Jan 4, 2022
@Rich-Harris Rich-Harris deleted the i1369/partial-headers branch January 4, 2022 11:15
@github-actions github-actions bot mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing of ServerResponse doesn't jive with possibly undefined cookies (TypeScript)
4 participants