Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] allow to render error pages from handleError #3235

Closed
wants to merge 3 commits into from

Conversation

nhe23
Copy link
Contributor

@nhe23 nhe23 commented Jan 7, 2022

Fixes #2824 by optionally rendering error pages if renderError is returned from the handleError hook. This solution is better than #3171 because the right status code is returned and the user can reload the page in order to try again.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2022

🦋 Changeset detected

Latest commit: 9ffac93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 7, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 9ffac93

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d8822630a7f40008ee4f72

@Rich-Harris
Copy link
Member

Thank you. Adding new API is unnecessary though — all we need to do is this...

// pseudo-code
try {
  return handle();
} catch (e) {
  handle_error(e);
  return render_error_page();
}

...and wrap all the error page rendering logic in a try-catch (previously, some of it was outside the try-catch) so that that's guaranteed not to throw. I've opened #3239, so I'll close this and #3171

@Rich-Harris Rich-Harris closed this Jan 7, 2022
@nhe23 nhe23 deleted the hooks-render-errors branch January 19, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a way to render an error page when there's an exception in a hook (e.g. handle)
2 participants