Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] prerendering with base path configured #3500

Merged
merged 4 commits into from Jan 22, 2022

Conversation

nhe23
Copy link
Contributor

@nhe23 nhe23 commented Jan 21, 2022

Fixes #3393, #2852 by considering config.path.base when prerendering.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2022

🦋 Changeset detected

Latest commit: b1527f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: b1527f5

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61eb4ad6e3c1080007d27eaf

@nhe23 nhe23 changed the title Prerendering base path [fix] prerendering with base path configured Jan 21, 2022
@Rich-Harris Rich-Harris merged commit 42027b1 into sveltejs:master Jan 22, 2022
@Rich-Harris
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prerendering broken when using a base path
2 participants