Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearer packaging error messages #3562

Merged
merged 11 commits into from Jan 27, 2022
Merged

Conversation

ignatiusmb
Copy link
Member

Closes #2951

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2022

🦋 Changeset detected

Latest commit: 69ebc4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 69ebc4c

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f278812d5e260007a4fe4c

@ignatiusmb ignatiusmb changed the title I2951/packaging ts error message clearer packaging error messages Jan 27, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. With a small question.

packages/kit/src/packaging/index.js Outdated Show resolved Hide resolved
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@Rich-Harris Rich-Harris merged commit 691ae7e into master Jan 27, 2022
@Rich-Harris Rich-Harris deleted the i2951/packaging-ts-error-message branch January 27, 2022 14:45
@jcalfee
Copy link

jcalfee commented May 14, 2022

Thanks .. I followed the help link to packaging and read all of that, but I'm not sure how to disable typescript so I don't need svelte2tsx and typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run package isn't playing nice without typescript
5 participants