Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include service-worker.js in manifest #3570

Merged
merged 1 commit into from Jan 28, 2022
Merged

include service-worker.js in manifest #3570

merged 1 commit into from Jan 28, 2022

Conversation

Rich-Harris
Copy link
Member

fixes #3187. service-worker.js is an anomaly because it's a generated file, but it lives among the contents of static, so it was overlooked previously. No test because the effects are only really observable in certain production environments (Cloudflare specifically, because the handler itself is responsible for serving assets), depending on how they work

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2022

🦋 Changeset detected

Latest commit: ec867f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: ec867f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f2cb67f0acb0000888f73f

Copy link
Contributor

@dreitzner dreitzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants