Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up docs for #3578 #3619

Merged
merged 5 commits into from Jan 29, 2022
Merged

follow up docs for #3578 #3619

merged 5 commits into from Jan 29, 2022

Conversation

ignatiusmb
Copy link
Member

Documentation to #3578

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@netlify
Copy link

netlify bot commented Jan 29, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 98153f4

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f5577c01a6ed0007e31add

documentation/docs/11-page-options.md Outdated Show resolved Hide resolved
documentation/docs/11-page-options.md Outdated Show resolved Hide resolved
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2022

⚠️ No Changeset found

Latest commit: 98153f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@benmccann benmccann merged commit d0310c1 into master Jan 29, 2022
@benmccann benmccann deleted the docs-3578 branch January 29, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants